search

LinkedEarth / Pyleoclim_util

Python Package for the Analysis of Paleoclimate Data. Documentation at
https://pyleoclim-util.readthedocs.io
GNU General Public License v3.0
88 stars 33 forks source link

add auto_time_params arg to series init #472

Closed alexkjames closed 11 months ago

alexkjames commented 1 year ago

Address Issue #469

I've just added an auto_time_params argument to Series, and nested the time name/unit logic within an if statement that relies on the value of auto_time_params.

This is the simplest fix to issue #469. We discussed having a way to switch a series in between having auto and not auto time params, but I'm not sure this is necessary. If it is I'm happy to create a function to do so, though I might suggest waiting until such a thing is requested/it becomes clear that we need it since creating Series objects is already pretty straightforward.

Was there anything else we wanted to do here?

CommonClimate commented 1 year ago

Thanks for doing this @alexkjames ! I'll review this week.

CommonClimate commented 1 year ago

I seem to remember @khider wanting auto_time_params = False by default. Did I misremember?

khider commented 1 year ago

I think we should have it True for a while so it mimics the behavior of the current version and have a warning that it will be set to False in subsequent releases.

CommonClimate commented 1 year ago

That sounds good. @alexkjames can you do that and update the PR?

CommonClimate commented 11 months ago

closes #469