LinkedEarth / Pyleoclim_util

Python Package for the Analysis of Paleoclimate Data. Documentation at
https://pyleoclim-util.readthedocs.io
GNU General Public License v3.0
87 stars 33 forks source link

MultivarDecomp.modeplot() arguments - new default + fix when archiveType is not provided #514

Closed khider closed 4 months ago

khider commented 7 months ago

When the archiveType is not provided in the GeoSeries, the map doesn't make much sense using the defaults:

Problem 1:

image

The work around is to set marker='o' but I would expect that by default, I get something better than question marks when archiveType (default for marker setting) is None. I would write a condition that if archiveType is None for all GeoSeries in the MultipleGeoSeries object, then set marker to 'o'.

Problem 2:

The legend on the right doesn't make sense when there are no archiveType provided. But when using the command: scatter_kwargs={'legend':False}, the colorbar disappears.

image

CommonClimate commented 7 months ago

Solution agreed upon by the High Council on 02/09/2024:

khider commented 4 months ago

Fixed with #525