[x] reform series.correlation() to work like Coherence.signif_test()
[x] modify correlation unit tests to account for new methods
[x] implement Surrogates for Coherence objects
To do:
[ ] enable fBm and power law Surrogates (emulate pens package)
[ ] unable surrogates for causality
[ ] implement Surrogates for Scalograms objects
While I was tinkering with Series.correlation(), I took the opportunity to also take care of #475
The most notable changes will therefore be for correlations, where the API was changed (sorry!). However, I did take pains to ensure backward compatibility with old terminology (isopersistent, isospec). At issue is the fact that we had various bits of code that did the same thing under different names. I renamed isopersistent to ar1sim and isospec to `phaseran1, but I'm open to doing it the other way around.
Note: this is time-sensitive as I was hoping to have this merged by 03/27 so @lionelvoirol can start working his spectral tests in the main branch, using this new infrastructure.
This addresses part of #228
Done:
phaseran()totsutilsTo do:
While I was tinkering with
Series.correlation(), I took the opportunity to also take care of #475The most notable changes will therefore be for correlations, where the API was changed (sorry!). However, I did take pains to ensure backward compatibility with old terminology (isopersistent, isospec). At issue is the fact that we had various bits of code that did the same thing under different names. I renamed isopersistent to
ar1simand isospec to `phaseran1, but I'm open to doing it the other way around.Note: this is time-sensitive as I was hoping to have this merged by 03/27 so @lionelvoirol can start working his spectral tests in the main branch, using this new infrastructure.