search

LinkedEarth / pylipd

Development repository for Python LiPD utilities
https://pylipd.readthedocs.io/en/latest/
Apache License 2.0
2 stars 0 forks source link

`.remove` is not working (i.e. not removing) #29

Closed khider closed 1 year ago

khider commented 1 year ago

To reproduce:

from pylipd.lipd import LiPD
data_dir = '../data/Euro2k'
d3 = LiPD()
d3.load_from_dir(data_dir)
d3.remove(collection_id="Eur-MaritimeFrenchAlps.B_ntgen.2012")
khider commented 1 year ago

Same problem with pop

varunratnakar commented 1 year ago

remove, pop work with dataset ids not collection ids.

khider commented 1 year ago

Got it. What are collection_id?

khider commented 1 year ago

@varunratnakar , I allowed for .pop and .remove to take a list rather than one name at a time in 9a2a82ebbfc564ec61bb51eca2aa64d34af67ef8 but since I don't know what collection_id is I didn't enable it. If that's something we should do, let me know.

varunratnakar commented 1 year ago

collection_id removed as it was confusing.. Will only take lists now