"wood" vs "tree" in LiPD

LinkedEarth / pylipd

Development repository for Python LiPD utilities

https://pylipd.readthedocs.io/en/latest/

Apache License 2.0

2 stars 0 forks source link

Closed khider closed 2 months ago

khider commented 2 months ago

The proper vocabulary name for this archiveType is wood per https://lipdverse.org/vocabulary/archivetype/. Therefore, for filtering purposes, one need to use wood as in:

However, when using the get_timeseries_essentials method, the archiveType is still tree. This is going to be confusing.

I suspect that tree is forced from wood somewhere in the code base.

khider commented 2 months ago

To reproduce, used the Pages2k folder from the tutorials

varunratnakar commented 2 months ago

I get the archiveType as "Wood" now.

khider commented 2 months ago

I still don't

varunratnakar commented 2 months ago

It is still working for me.. Could you paste the whole code that you are running ?

khider commented 2 months ago

It's the one attached to LiPDSeries, sorry, just realized this

varunratnakar commented 2 months ago

Ah ok. So it's the archiveType attached to variables. I've added a parsing step for archiveType at the variable level as well. Please try now.

khider commented 2 months ago

All good!