search

LinkedInAttic / LayoutKit

LayoutKit is a fast view layout library for iOS, macOS, and tvOS.
http://layoutkit.org
Apache License 2.0
3.16k stars 267 forks source link

Removed pre-install scripts #117

Closed jingwei-huang1 closed 7 years ago

jingwei-huang1 commented 7 years ago

The current build script causes the error as below,

$ xcrun simctl delete 22FA2149-1241-469C-BF6D-462D3837DB72
Invalid device: 22FA2149-1241-469C-BF6D-462D3837DB72
The command "xcrun simctl delete 22FA2149-1241-469C-BF6D-462D3837DB72" failed and exited with 162 during .
jingwei-huang1 commented 7 years ago

@nicksnyder Do you remember the reason why you want to delete two simulators before running? https://github.com/linkedin/LayoutKit/pull/87

codecov-io commented 7 years ago

Codecov Report

Merging #117 into master will increase coverage by 0.03%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage    92.3%   92.33%   +0.03%     
==========================================
  Files          53       53              
  Lines        3053     3053              
==========================================
+ Hits         2818     2819       +1     
+ Misses        235      234       -1
Impacted Files Coverage Δ
LayoutKit/Views/ReloadableViewUpdateManager.swift 92.64% <0%> (+1.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 278d1c2...d752de4. Read the comment docs.