search

LinkedInAttic / LayoutKit

LayoutKit is a fast view layout library for iOS, macOS, and tvOS.
http://layoutkit.org
Apache License 2.0
3.16k stars 267 forks source link

Fixed crash issue in sample app - Simple solution #121

Closed jingwei-huang1 closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #121 into master will decrease coverage by 0.03%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   92.35%   92.32%   -0.04%     
==========================================
  Files          58       58              
  Lines        3311     3311              
==========================================
- Hits         3058     3057       -1     
- Misses        253      254       +1
Impacted Files Coverage Δ
LayoutKit/Views/ReloadableViewUpdateManager.swift 91.17% <0%> (-1.48%) :arrow_down:
LayoutKit/Views/ReloadableViewLayoutAdapter.swift 83.15% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9667640...a1b677f. Read the comment docs.

jingwei-huang1 commented 7 years ago

The current solution is not perfect. Do you guys think if I should create an issue to fix it properly in the future?