Allow isSelectable overridden in TextViewLayout Configure

LinkedInAttic / LayoutKit

LayoutKit is a fast view layout library for iOS, macOS, and tvOS.

http://layoutkit.org

Apache License 2.0

3.16k stars 267 forks source link

Allow isSelectable overridden in TextViewLayout Configure #153

Closed jingwei-huang1 closed 7 years ago

jingwei-huang1 commented 7 years ago

Originally, we don't allow isSelectable overridden in TextViewLayout because there was a view issue. After re-tested it on iOS 10/11, it looks OK. As a result, isSelectable moved to before configure, so that it can be overridden in configure block.

chriscuecal commented 7 years ago

Is there any updates on if this can be merged? Thanks!

jingwei-huang1 commented 7 years ago

@chriscuecal Sorry for the late reply. I was trying to test on iOS 8/9 to see if I can reproduce the issue. Since it can't be reproduced anymore, I removed the entire line and chose the default value from UITextView instead. I will merge it once @nicksnyder approves it.

chriscuecal commented 7 years ago

@jingwei-huang1 awesome thank you!

spekke commented 7 years ago

Sweet! Thanks!