Closed e-liu closed 7 years ago
You need to update the tests. They are failing.
Fixing
@nicksnyder I moved the pendingInsertedIndexPaths.removeAll()
in flushPendingInserts
call back outside of the completion block. It seems like calling it directly after calling reload and not waiting until completion is the right thing to do, is this correct?
@e-liu yes, that makes sense to me. We handle them synchronously by queueing up the animation. We don't need to wait for the animation to finish before considering them handled.
Currently the completion callback when performing a reload with batch updates is being called prematurely because performing batch updates happens asynchronously on the animation thread. We should use the completion block provided by performBatchUpdates(:) instead