LinkedInAttic / Zopkio

A Functional and Performance Test Framework for Distributed Systems
Apache License 2.0
159 stars 33 forks source link

get_active_config() trigger traceback if config is not found. #108

Open pkilner opened 8 years ago

pkilner commented 8 years ago

In the code it says: "returns an empty string if the config is not found", see below.

def get_active_config(config_option, default=None): """ gets the config value associated with the config_option or returns an empty string if the config is not found :param config_option: :param default: if not None, will be used :return: value of config. If key is not in config, then default will be used if default is not set to None. Otherwise, KeyError is thrown. """ return _active_config.mapping[config_option] if default is None else _active_config.mapping.get(config_option, default)

However this is not the case and the program exits.

7,668 zopkio.test_runner [INFO] Setting up configuration: single execution 2016-06-29 07:37:17,669 zopkio.test_runner [ERROR] Aborting single execution due to setup_suite failure: Traceback (most recent call last): File "/usr/local/lib/python2.7/site-packages/zopkio-0.2.5-py2.7.egg/zopkio/test_runner.py", line 189, in run self.deployment_module.setup_suite() File "perf_deployment.py", line 7, in setup_suite deploy_cluster.launch() File "../lib/deploy_cluster.py", line 49, in launch runtime.get_active_config('output_dir') File "/usr/local/lib/python2.7/site-packages/zopkio-0.2.5-py2.7.egg/zopkio/runtime.py", line 204, in get_active_config return _active_config.mapping[config_option] if default is None else _active_config.mapping.get(c

It should return a empty string.