LinkedInAttic / hopscotch

A framework to make it easy for developers to add product tours to their pages.
Apache License 2.0
4.19k stars 664 forks source link

Refactor build to generate UMD and AMD artifacts #337

Closed ryanone closed 7 years ago

ryanone commented 7 years ago

Primary goal of this PR is to move away from src files containing UMD (or AMD) wrappers to instead allow for src files to be written as ES6 modules, and rely on the build to generate UMD/AMD artifacts. rollup (via grunt-rollup) is used along with babel (rollup-plugin-babel) are used to generate UMD and AMD artifacts, and to transpile ES6. In the dist/ directory, we output hopscotch_amd.js and hopscotch_amd.min.js, which are AMD artifacts. I also updated the Travis CI file, by updating the versions of Node used. All existing grunt tasks maintain functionality, and all existing artifacts remain. Only the AMD artifacts were added.

Testing done includes running all tasks, and running the Jasmine tests