Fixed test execution and added yarn.lock so it stays that way

LinkedInAttic / hopscotch

A framework to make it easy for developers to add product tours to their pages.

Apache License 2.0

4.2k stars 666 forks source link

Fixed test execution and added yarn.lock so it stays that way #360

Open Benjamin-Dobell opened 6 years ago

Benjamin-Dobell commented 6 years ago

Fixed the build and test execution.

It was actually surprisingly complicated to come up with a set of dependency versions that work. For example, newer versions of rollup seem to contain a bug that was incorrectly tree-shaking away code that causes tests (and the corresponding real functionality) to fail.

As such I've added a lock file so that no-one else has to go through the painful dependency versioning trial and error I just went through!

Benjamin-Dobell commented 6 years ago

I should probably note that grunt-template-jasmine-requirejs is no longer maintained (last update around 3 years ago), so I've switched to a fork that is maintained.