search

LinkedInAttic / inject

AMD and CJS dependency management in the browser
http://www.injectjs.com
Other
464 stars 48 forks source link

Added a release task check to ensure the branch is master. #295

Closed gvsboy closed 10 years ago

gvsboy commented 10 years ago

I added a check to the "release" Grunt task, ensuring the current branch is master before continuing the process. We could use a similar approach to validate other pre-release criteria. Let me know what you think.

jakobo commented 10 years ago

I think it's a good thing. I'll check the PR in the morning. Thanks for doing this work Kevin!

--Jakob

On Tue, Jan 7, 2014 at 4:24 PM, Kevin Mikles notifications@github.comwrote:

I added a check to the "release" Grunt task, ensuring the current branch is master before continuing the process. We could use a similar approach to

validate other pre-release criteria. Let me know what you think.

You can merge this Pull Request by running

git pull https://github.com/gvsboy/inject master

Or view, comment on, or merge it at:

https://github.com/linkedin/inject/pull/295 Commit Summary

  • Added a release task check to ensure the branch is master.

File Changes

  • M gruntfile.jshttps://github.com/linkedin/inject/pull/295/files#diff-0(23)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/linkedin/inject/pull/295 .

jakobo commented 10 years ago

See line comment for cleaning up trim.

gvsboy commented 10 years ago

I totally overlooked native trim. Are you cool with me using it instead? If not I can update my trim function.

jakobo commented 10 years ago

Probably wise to use native trim

On Monday, January 13, 2014, Kevin Mikles wrote:

I totally overlooked native trim. Are you cool with me using it instead? If not I can update my trim function.

— Reply to this email directly or view it on GitHubhttps://github.com/linkedin/inject/pull/295#issuecomment-32231552 .

--Jakob

jakobo commented 10 years ago

Please also modify your commit message to match our gitcommit template, as it helps with changelog generation.

https://github.com/linkedin/inject/blob/master/gitcommit

<type>(<scope>): <subject>

<body>

<footer>

<type>:    feat, fix, docs, style, refactor, test, chore
<scope>:   Object, file, or flow impacted
<subject>: Present tense, don't capitalize the first word, no period
<body>:    Present tense, explain motivation
<footer>:  Breaking changes require "BREAKING CHANGE" + mitigation

If you need info on how to edit a commit message: http://stackoverflow.com/questions/179123/how-do-i-edit-an-incorrect-commit-message-in-git

gvsboy commented 10 years ago

I updated my previous commit message and added the trim commit. Let me know if I'm using the template format correctly.