search

LinkedInAttic / sepia

Sepia is a VCR-like module for node.js that records HTTP interactions, then plays them back exactly like the first time they were invoked
Apache License 2.0
279 stars 32 forks source link

nodejs 6 issues #15

Open satazor opened 8 years ago

satazor commented 8 years ago

I've got a project with fixtures generated using nodejs 4 but the same fixtures do not work in nodejs 6 because they have a different signature. It seems that nodejs 6 changed some internals that are causing this issue.

satazor commented 7 years ago

After investigating, the issue is with JSON.stringify here: https://github.com/linkedin/sepia/blob/master/src/util.js#L339

Node 4 and Node 6 have discrepancies in the way they output unicodes.. one simply output as text and other as ASCII text (e.g.: \uxxxx).

One way to solve it is to base64 the JSON.stringify ouput before passing it to crypto.

jimmyeisenhauer commented 7 years ago

I just went from node 4.4.3 to 6.9.1 and didn't see any issues. Did they fix something in 6?