search

LinkedInAttic / simoorg

Failure inducer framework
https://github.com/linkedin/simoorg/blob/master/docs/user_guide.md
Apache License 2.0
190 stars 45 forks source link

Allow overriding of plugin paths #5

Open srikanth-viswanathan opened 8 years ago

srikanth-viswanathan commented 8 years ago

Currently the plugin paths are hardcoded in the python code. The deployment location of custom plugins might be different than the deployment location of simoorg, so it would be nice to allow the plugin paths to be overriden. My suggested way of doing this would be to add an optional parameter in the fate book to control the search location for plugins:

plugin_base_path: /my/custom/plugin/deployment/location
topology_plugin: MyTopologyPlugin

Currently, I have it working by starting simoorg inside my custom startup script where I override the relevant atropos.*_PLUGIN_PATH global variable, but I'd rather not do this if simoorg supported custom plugin paths out of the box.

MayureshGharat commented 8 years ago

Sounds reasonable to do.

MayureshGharat commented 8 years ago

Good to work on it. Feel free to submit a PR when done :)

MayureshGharat commented 8 years ago

Hey @srikanth-viswanathan, Just wanted to see if you are actively working on the current issues that you raised with Simoorg. they seem to be really nice suggestions. Let me know :)

srikanth-viswanathan commented 8 years ago

Haven't had time to work on these yet. I hope to do a couple next week.