LinkedInAttic / venus.js

where bugs go to die
http://venusjs.readthedocs.io/en/latest/
Other
298 stars 44 forks source link

JUnitReporter doesn't output "total" tests #335

Open benvinegar opened 10 years ago

benvinegar commented 10 years ago

Output looks like:

<testsuite name="myspec.spec.js" failures="0" tests="" time="">

Since # of tests is absent, some CI systems believe that no tests have been executed, and consider the build a failure.

The issue doesn't seem to be with the reporter, but rather that test.results.done.total isn't populated.

Value of test.results.done.total at reporting time:

{ failed: 0, total: null }

Currently digging further, but thought I'd throw this up now.

benvinegar commented 10 years ago

I suspect the issue may be that the <testsuite> tag is output before the suite has actually run. So it always puts out failed="0" and total="", regardless of the outcome.

sethmcl commented 10 years ago

Hmm I can take a look later tonight. Let me know if you found a fix in the meantime. Thanks!