search

LinkedInAttic / venus.js

where bugs go to die
http://venusjs.readthedocs.io/en/latest/
Other
298 stars 44 forks source link

Venus inconsistently displays errors in Phantom #341

Open whastings opened 9 years ago

whastings commented 9 years ago

I have noticed that sometimes I'll run a spec with Venus and Phantom and it'll report 0 tests executed and nothing else. If I run the test in the browser, I can usually see a JS error is the cause, but sometimes the error occurs in Phantom but not the browser.

Sometimes Venus and Phantom will show the actual error, but not always. For example, I can put throw new Error('some text'); in my describe, and sometimes it'll be in the output, but most of the time it won't. Venus won't report the error about 5 out of 6 times.

Is there anything we can do to get the error reporting working 100% of the time?

BTW, I'm using Venus 2.3.3 and Phantom 1.9.1.

bradcypert commented 8 years ago

361 fixes this :wink:

bradcypert commented 8 years ago

@whastings Update to the latest version of Venus. My PR #361 fixed this issue and was merge in last week. :smile: