LinkedInAttic / venus.js

where bugs go to die
http://venusjs.readthedocs.io/en/latest/
Other
298 stars 44 forks source link

Restructure venus temp #355

Open geoffberger opened 9 years ago

geoffberger commented 9 years ago

removed console.logs from executor

allows for both executor and testcase to read from a temp directory of .venus_temp-#PORTNUMBER# verses straight .venus_temp

removed unused startingPort variable

removed commented out code from getHttpRoot

cleaned up static content setup and created venus temp helper

put back me original pirate locale, ok that wasnt funny, whatever

created port and tempDir constants

refined logic and put in error handling for new bits of code

created getTempDir and resolveTempDir utilities in fsHelper

added new error string to locale file

added tests to support changes to executor namely: sendGenericError, setPort, and some other one I forgot about, iono look at the code

created fsHelper for newly created fsHelper utilities

added fsHelper spec to test_suite

resolved rebase conflict on testcase.spec.js

moved directory operations over to test helpers to clean up test files

removed console.log from test helper

adding debug statements and translations

updated temp dir

allowed for test directory to be deleted right before the test shuts down and strengthened some things

Fixing testcase tests

updated tests based off of recent code changes

added clean command so all temporary directories can be removed

yes, I am THAT guy who broke the build

added node-uuid to package.json

because I dont know how to program, lets actually pass _.isNull some input

updated tempDir to point to proper tempDir based off of our discussions in PR 350

updated executor to use a guid instead of the port so we can guarantee the temp directory on the file path will be unique - the same thing is also achieved with the venus server

updated testcase to use guid instead of port to make things unique

updated docs and variable reference to resolveTempDir in fsHelper.js

updated executor test to reflect guid being used in place of port

updated testcase test to reflect guid being used in place of port

added test for using guid within executor

make clean a promise and added tests to support the clean command and its functionality

removed reference to dev box

corrected failing clean unit test to actually work

removed unnecessary call to setMaxListeners

made setPort test more efficient

removing unused deferred cal

updated paths based on testing file structure refactoring

added back fsHelper because for some reason evil git rebase removed the file