LinkedSoftwareDependencies / Components.js

🧩 A semantic dependency injection framework
https://componentsjs.readthedocs.io/
Other
41 stars 6 forks source link

fix: enable webpacking by replacing fs.readFile with require on json documents #109

Closed jeswr closed 1 year ago

jeswr commented 1 year ago

Resolves the error observed in https://github.com/comunica/comunica/issues/1112 when webpacking with { target: node }

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3458250993

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 2911813325: 0.0%
Covered Lines: 1360
Relevant Lines: 1360

💛 - Coveralls
rubensworks commented 1 year ago

I vaguely remember doing something similar like this in the past, but things breaking then (somewhere).

Could you have a look to see what happens when this change is applied in Comunica and CSS? If this change doesn't cause any problems there, then this should be fine.

jeswr commented 1 year ago

CSS works fine Comunica also works fine*

*Comunica complianed about the relative install at first because, for some reason, when you do a yarn install the .ts files get copied into the node_modules and they are referred to rather than the .js files that are built. After manually removing the .ts files in the relative installation it worked (note that these files are excluded when this is installed from npm so this is not an issue).

rubensworks commented 1 year ago

Thanks! Released as 5.3.2.