Closed jeswr closed 1 year ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Totals | |
---|---|
Change from base Build 2911813325: | 0.0% |
Covered Lines: | 1360 |
Relevant Lines: | 1360 |
I vaguely remember doing something similar like this in the past, but things breaking then (somewhere).
Could you have a look to see what happens when this change is applied in Comunica and CSS? If this change doesn't cause any problems there, then this should be fine.
CSS works fine Comunica also works fine*
*Comunica complianed about the relative install at first because, for some reason, when you do a yarn install
the .ts
files get copied into the node_modules
and they are referred to rather than the .js
files that are built. After manually removing the .ts
files in the relative installation it worked (note that these files are excluded when this is installed from npm so this is not an issue).
Thanks! Released as 5.3.2.
Resolves the error observed in https://github.com/comunica/comunica/issues/1112 when webpacking with { target: node }