LinkedSoftwareDependencies / Components.js

🧩 A semantic dependency injection framework
https://componentsjs.readthedocs.io/
Other
41 stars 6 forks source link

feat: fix bug and expose instantiated resource info #94

Closed Falx closed 2 years ago

Falx commented 2 years ago

Purpose

This PR has two purposes:

Exposing information on instantiated resources

This allows users of Componentjs to query the instantiated registry for types. In our use case this allows us to discover certain instantiated classes that implement a given interface.

New public methods:

Fixed a bug

A bug was discovered where blankNodes and literal could overwrite eachother in the internal registry. This was fixed by replacing all indexing code of resource.value to termToString(resource.term) and vice verca with stringToTerm(resourceId).

A new dependency on rdfjs-string was added for that.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2299639781

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 1922210134: 0.0%
Covered Lines: 1258
Relevant Lines: 1258

💛 - Coveralls
rubensworks commented 2 years ago

Super, thanks!

Released as v5.1.0.