fix: improved handling of constructor arguments of type unknown.

[wkerckho]

Relevant issue: Components.js related issue in the Solid Community Server https://github.com/CommunitySolidServer/CommunitySolidServer/issues/1182

Purpose

The goal of these changes is to ensure that primitive constructor arguments preserve their data type when using unknown as argument type.

Changes

I've updated the method hasValueType in ParameterPropertyHandlerRange to perform additional handling in case the type is a ParameterRangeWildcard (the type that is generated when using unknown).

• A private utility method hasLiteralValueType was added to encapsulate the handling of a literal.
• I've refactored the literal case to call this method
• The case when type is a ParameterRangeWildcard, now extracts the configured type of the argument and also calls hasLiteralValueType (when the found configured type is not string).

I've added testing for various cases of instantiations when using an unknown constructor argument in the file instantiateFile-test.

Improvements

Possible improvements for this fix that can be performed by someone that is more familiar with the Components.js codebase:

• Because hasValueType has side-effects, it was not trivial to extract the logic that performs handling of the literals in an utility method. Hence I chose to throw an error when no handling was performed, allowing the calling code in hasValueType to continue processing when this occurs (instead of returning). This could be confusing, so maybe some refactoring is required.
• Testing: I've provided test cases in the form of integration tests, but ideally this functionality is also checked in ParameterPropertyHandlerRange.test.ts (but it was a bit daunting for me to make additions there).

[coveralls]

Pull Request Test Coverage Report for Build 2320004393

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 36 of 36 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 2299708934:	0.0%
Covered Lines:	1265
Relevant Lines:	1265

---

💛 - Coveralls

[wkerckho]

Incorporated the requested changes and updated ParameterPropertyHandlerRange-test.ts:

• Moved literal test cases for hasValueType into new section which specifically tests interpretValueAsType
• Added two new test cases for hasValueType, which checks if interpretValueAsType is called the appropriate number of times, with the expected arguments (for literal types).

[rubensworks]

Thanks for this! Released as 5.2.0.