Closed chrisr0892 closed 1 month ago
Name | Link |
---|---|
Latest commit | c4c2681d40ed8832c3e5b31d444b23355669f6db |
Latest deploy log | https://app.netlify.com/sites/linkta-core/deploys/66b24d5c9ba91b00081b5165 |
Deploy Preview | https://deploy-preview-369--linkta-core.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Thanks for the good work!
There's a Loader component in
/components/common
, consider moving the loading functionality from the UserInputForm to this Loader component. Since multiple parts of the app use the Loader, we should make sure this loader is reusable and comprehensive for generic use and add a bit more for LLM interactions.Currently, the LLM loader is needed in 2 areas so please make sure you incorporate the loader in the respective components.
- UserInputForm
- OptionsMenu (regenerate function)
For LLM interactions, it'd be great to show additional info to reassure users that the process might take a while due to AI processing. Not a requirement and only if you have the capacity, adding a button for the user to cancel the query could help improve our UX too.
For styling, if we are making a reusable loader, prioritize using a CSS object over inline styling if time allows.
Thanks for the review! I moved the loader to existing Loader.tsx component so that it can be reusable and incorporated it in UserInputForm and OutputVisualizationPage (regenerate).
Description
Loader
component with MUICircularProgress
.UserInputForm
OutputVisualizationPage
with zustand state to allow for re-rendering whenregenerate
is clicked.Fixes #78
Type of change
How Can this be tested? Testing Plan to review this PR
UserInputForm.tsx
andOutputVisualizationPage.tsx
/generate
route:Generate
button to create a new LinktaFlow.•••
icon and selectRegenerate
.Checklist:
Additional Information: