LinusBorg / portal-vue

A feature-rich Portal Plugin for Vue 3, for rendering DOM outside of a component, anywhere in your app or the entire document. (Vue 2 version: v2.portal-vue.linusb.org)
http://portal-vue.linusb.org
MIT License
3.9k stars 187 forks source link

Not working with Vue 2.7.0 #376

Closed optsing closed 2 years ago

optsing commented 2 years ago

After upgrade Vue from 2.6.14 to 2.7.0 PortalVue stopped render anything.

The following errors are displayed in DevTools:

[Vue warn]: $listeners is readonly. [Vue warn]: $attrs is readonly.

xrado commented 2 years ago

also noticed

Sidnioulz commented 2 years ago

Could either of you please test with 2.7.3? My colleagues are saying portal-vue works with that version.

xrado commented 2 years ago

tested again with the latest 2.7.5 and getting same errors as above

LinusBorg commented 2 years ago

A reproduction would be helpful, can you put something together?

This error appeared ages ago during unit test, but I have no idea how 2.7 could trigger that again, and do so at runtime.

xrado commented 2 years ago

I found the issue, it is the same as here https://github.com/LinusBorg/portal-vue/issues/201 works fine now

LinusBorg commented 2 years ago

Great, thanks fornrhe Feedback.

Solution found in r linked issue