search

LinusBorg / vue-simple-portal

A simpler Portal implementation focussed on moving slot content to the end of the body element
Other
223 stars 28 forks source link

"Append" Code is in the wrong method #4

Closed LinusBorg closed 5 years ago

LinusBorg commented 5 years ago

https://github.com/LinusBorg/vue-simple-portal/blob/72cdea336b498b233ee5db8df0fe1bd4371ff7d5/src/components/Portal.js#L62-L69

The above lines belong inside of the mount() method, as we want the append prop to define insert position of the portal'ed content, not of the container element.

Also should be named "prepend".  🤭