search

LinusSkucas / communications-skill

An intercom, messaging, and (video) calling skill for Mycroft!
Apache License 2.0
16 stars 6 forks source link

Let specify the device to announce #8

Open adocampo opened 5 years ago

adocampo commented 5 years ago

I think it should be great to let the user to specify to what device(s) the sentence should be announced.

Hey Mycroft, announce on kitchen "Let me know when dinner's ready."

and on the kitchen's mycroft, should be listened something like:

You have a new message from living room: "Let me know when dinner's ready."

So, the device should have a friendly name for this skill, it should be specified on the skill settings or if it is in blank, grabbing the name of the mycroft device as default. (So, for example, I have named my mark I as "mark I", but I could specify a friendly name "kitchen" under the communications settings as it will be placed on the kitchen when the mark II arrives, and the mark II should use for example "living room").

As default a global announce can be of use, but I would rather prefer to say something like:

Hey Mycroft, announce to everyone "The dinner's ready!"

LinusSkucas commented 5 years ago

Hi @adocampo Thanks for all the feedback!

I was thinking that this would be more of a messaging feature, but I had it in mind, while I was developing the skill, and it will be a feature that I will add.

For the name of the device, I'm going to use the name, along with the description, defined on mycroft home, just to make it easy for the user.

LinusSkucas commented 4 years ago

Hi @adocampo Thanks for waiting. I've got a basic version of the messaging function pushed to the messaging branch of the repo, so if you want to, install the skill using msm, switch to the messaging branch, then restart the device. Do this on the other devices too. Then try saying something like "message (device) dinner's ready!

Thanks

adocampo commented 4 years ago

Hi @LinusS1, love to see this! I can't try it right now, I'm painting and wiring my new home and I have all the Mycroft devices on boxes. I'll report back in a few days