LinusU / node-appdmg

💾 Generate your app dmgs
MIT License
1.7k stars 152 forks source link

support "position" value for "type" field #102

Closed rbkreisberg closed 8 years ago

rbkreisberg commented 8 years ago

This makes it possible to position hidden folders out of the initial dmg Finder window. see the following discussion https://github.com/LinusU/node-appdmg/issues/45

This change adds "position" to the enum list for the "type" field in the "contents" array objects

rbkreisberg commented 8 years ago

This was working (intentionally, I think?) until the recent change that added schema enforcement.

@LinusU let me know if anything further is needed. Thanks for the great package.

cstruct commented 8 years ago

Looking good. LGTM once the typo in the test file is fixed.

LinusU commented 8 years ago

LGTM when typo is fixed

rbkreisberg commented 8 years ago

@cstruct @LinusU thanks! typo fixed