search

LinusU / node-appdmg

💾 Generate your app dmgs
MIT License
1.68k stars 152 forks source link

Create target upfront #112

Closed cstruct closed 6 years ago

cstruct commented 8 years ago

Open target with write and exclusive flag. This closes #65

albinekb commented 8 years ago

ping @cstruct 🦄

cstruct commented 6 years ago

Rebased on master and issues have been fixed.

albinekb commented 6 years ago

Good job @cstruct 🙌

LinusU commented 6 years ago

That last commit, won’t that open us up to leaving empty files behind?

cstruct commented 6 years ago

Yes it will... Adding the cleanup should be moved to the callback of the Looking for target step since it's the first place we know we won't delete a preexisting file. I'll fix it this afternoon.