Chinese Title Bug - Githubissues

michaelmou commented 7 years ago

Hey guy, thanks for your contributions , this project is awesome. But I got a little bug of that: When I type a title to Chinese for the process, it's background can not display(like a set a null background). thank you

alexshen commented 7 years ago

I have a similar issue with the icon of a content. If I set the `name' property containing Chinese characters, the icon becomes a folder.

xiaolouxinyue commented 7 years ago

有解决么？中文的问题？

xiaolouxinyue commented 7 years ago

Any solution for Chinese title ?

hankbao commented 7 years ago

I can confirm this bug with the latest appdmg.

StinsonZhao commented 6 years ago

Same problem. Expect solution.

sjchao commented 6 years ago

Finally, I got it!!! Chinese in title, will cause volume name is empty, then the file .DS_Store will not be written correctly. The code is in this project https://github.com/LinusU/node-alias

  info.volume = {
    name: addon.getVolumeName(volumePath), //Chinese in title, name will be empty
    created: volumeStat.ctime,
    signature: 'H+',
    type: (volumePath === '/' ? 'local' : 'other')
  };

https://github.com/LinusU/node-alias/blob/fb006c2ad35af646193e8744d7b43ef95c495af6/lib/create.js#L66

I don't know why need to call a c++ function, but when I change it from addon.getVolumeName(volumePath) to volumePath.substring(volumePath.lastIndexOf('/')+1), it works. On my Macbook, this file is located at /usr/local/lib/node_modules/appdmg/node_modules/macos-alias/lib/create.js