LinusU / node-appdmg

💾 Generate your app dmgs
MIT License
1.68k stars 152 forks source link

Cannot set both `background` and `background-color` #135

Open sindresorhus opened 7 years ago

sindresorhus commented 7 years ago

I would like to use a transparent image with an arrow and then set the background color using background-color, so it's easily configurable, but it seems setting a background makes the background-color config not apply.

develar commented 7 years ago

@sindresorhus Do you use electron-builder or appdmg directly?

sindresorhus commented 7 years ago

@develar I'm using it directly, here: https://github.com/sindresorhus/create-dmg/blob/9bf900661b99dd263936c349bcac5866144f90b2/cli.js#L44-L46

develar commented 7 years ago

@sindresorhus Is there anything wrong in the electron-builder or do you use it not for electron application?

mikaturk commented 7 years ago

@develar he's making a wrapper CLI to make it even easier to create DMGs (correct me if I'm wrong @sindresorhus) https://twitter.com/sindresorhus/status/846416556754010112

develar commented 7 years ago

@mikaturk What can be easier than just set dmg target for electron-builder ;) (and it is default target for macOS) ;)? @sindresorhus uses electron-builder and, so, I am wonder why such tool was required.

mikaturk commented 7 years ago

@develar probably to make the lives of everyone on the internet easier, he he has a problem, he fixes it, and everyone on the internet who has the same problem just uses his utilities.

sindresorhus commented 7 years ago

@develar I made it to ease creation of DMGs for native apps, not Electron apps.

LinusU commented 7 years ago

I'm on vacation so I won't be able to fix this right away, but it's probably just an if-statement or two that needs to be updated...

LinusU commented 7 years ago

Actually, after quickly glancing the code it looks like this is a bug in node-ds-store

mikaturk commented 7 years ago

@linusu have a nice vacation 😀

deadcoder0904 commented 5 years ago

Any progress on this? I use create-dmg & would love to have background & background-color :)

LinusU commented 5 years ago

This probably requires a complete implementation of the ds-store format, currently we are just changing some bytes in a template 😬