search

LinusU / node-appdmg

💾 Generate your app dmgs
MIT License
1.68k stars 152 forks source link

Doesn't work on Node 12 — PRs submitted for dependencies #181

Open argv-minus-one opened 5 years ago

argv-minus-one commented 5 years ago

Appdmg currently doesn't work on Node 12, because compilation of native code in two dependencies was broken by a change in the V8 API.

The dependencies in question are macos-alias (via ds-store) and capture-window, all of which you own. I have submitted PRs LinusU/node-capture-window#2 and LinusU/node-alias#16 to fix this problem by converting them to use N-API, which unlike the V8 API is guaranteed to remain stable. When I manually applied them to my local copy of appdmg, it built successfully and all tests passed on Node 12.

In the mean time, in case anyone else needs it, my fork of appdmg has a branch “node-12-temporary-fix”, which brings in the patches to macos-alias and capture-window. To use it, in package.json, set the version of your appdmg dependency to argv-minus-one/node-appdmg#node-12-temporary-fix. Example:

{
    "dependencies": {
        "appdmg": "argv-minus-one/node-appdmg#node-12-temporary-fix"
    }
}
meekaah commented 5 years ago

thanks @argv-minus-one for the workaround i just hope your PR makes it in soon