search

LinusU / node-appdmg

💾 Generate your app dmgs
MIT License
1.69k stars 152 forks source link

Add support for creating APFS disk images #221

Closed zorgiepoo closed 1 year ago

zorgiepoo commented 1 year ago

This adds support for creating APFS disk images which require macOS 10.13 or newer.

I tested this change locally with appdmg and verified generating both HFS+ and APFS disk images still work. I slightly changed the attach code to specify the mountpoint instead of fetching it from stdout for this change.

The use case is not wanting to support older OS systems for app disk images and not wanting to use HFS+, which while testing I've seen have worse performance for extraction*. Simply put, APFS is a more modern filesystem.

(*tested on macOS 13.0.1 with an app like VLC.app 3.0.18 (arm64; ~134 MB) under heavier compression using ULMO or UDBZ with Finder and have seen ~2x performance difference; e.g. 3-4 sec vs 6-8 sec) (hdiutil is not measured because its disk image mounting implementation is slower as of current writing and doesn't well model a user using the dmg)

zorgiepoo commented 1 year ago

@LinusU Hi friendly ping on this. We'd like to also use this in another project (create-dmg) that depends on node-appdmg.

220 is also a related change but that one should be an easy one.

LinusU commented 1 year ago

Thank you for your work on this! 🙏

LinusU commented 1 year ago

Released as 🚢 0.6.6 / 2023-02-03