search

LinusU / node-appdmg

💾 Generate your app dmgs
MIT License
1.7k stars 153 forks source link

Node 0.11 compatibility #46

Closed joshuawarner32 closed 9 years ago

joshuawarner32 commented 9 years ago

Related to an issue I filed on one of the dependencies: https://github.com/LinusU/fs-xattr/issues/3. App-dmg is the project I really care about adding 0.11 compatibility for. I've fixed fs-xattr locally (using https://github.com/rvagg/nan), and I'll make a PR to that repository when I get everything worked out.

I'm seeing similar issues with at least one more transitive dependency: node-appdmg -> ds-store -> macos-alias

However, I can't find the source for macos-alias to make updates there. @LinusU, I see that's under your username on npmjs.org; please advise.

LinusU commented 9 years ago

Oh, it's name is node-alias on Github... That isn't too good.

I'll add the repository field to the package.json so that it links directly to the repo.

LinusU commented 9 years ago

The npm page for macos-alias should be more informative now.

screen shot 2014-12-06 at 13 56 19

joshuawarner32 commented 9 years ago

To close the loop a little on this, I filed this PR for macos-alias: https://github.com/LinusU/node-alias/pull/6.

I think that's the last one needed - it covers the rest of the errors I was seeing when trying to import the 0.2.2 version. Npm is giving me shit when doing npm link of these highly-nested dependency structures (pulling in the wrong sources) - so it's hard to tell for sure that npm isn't stopping after a certain number of errors or something.

All of that is a very round-about way of saying, "Once you accept that PR, it'd be awesome if you could publish an official version of appdmg referencing the new changes."

LinusU commented 9 years ago

I made some comments on your pull request. As soon as we merge I will make sure to push a new appdmg as well :beers:

LinusU commented 9 years ago

Almost forgot, but now it is done! :fireworks:

Please let me know if version 0.2.3 that I just published to npm works for you :)

joshuawarner32 commented 9 years ago

0.2.3 works perfectly, thanks!