Better linux support - Githubissues

LinusU / node-loudness

🔊 A node.js library to control the systems output volume

MIT License

125 stars 40 forks source link

Better linux support #7

Open elderapo opened 7 years ago

elderapo commented 7 years ago

This pull request fixes:

[x] Muting/unmuting (#4).
[x] setVolume previously wasn't working as intended for example: setVolume(15, cb) was setting volume to 16 instead of 15 but setVolume(50, cb) was correctly setting volume to 50. Now it works for all the values 0-100%.

Since only @RyanAfrish7 (Ubuntu 16.04 LTS) and I (Ubuntu 14.04 LTS) reported problems fixed in this pull request I assume these errors only appeared on various Ubuntu distributions.

elderapo commented 7 years ago

Oh.. I just realized I made a mess by including pull request with windows support as well. Will try to fix it asap.

elderapo commented 7 years ago

I did my best to clear the mess I made. If it's still not acceptable let me know and I will just open a new "clear" pull request.