search

LinusU / react-native-get-random-values

A small implementation of `getRandomValues` for React Native
MIT License
350 stars 48 forks source link

Question: does it need "expo-random"? #21

Closed hirbod closed 4 years ago

hirbod commented 4 years ago

Hey @LinusU,

I've seen so many confusing issues, docs and blogs on this topic but one thing I'm still unsure about: do we still have to install "expo-random" in Expo SDK 39 or is it enough to install your library now to polyfill?

harshmaur commented 4 years ago

Same question!

LinusU commented 4 years ago

Sorry for the late reply! You do not need to install expo-random.

If there is anything that could be more clear in the documentation I would love a pull request!

hirbod commented 4 years ago

Yeah, a hint about that fact :)

LinusU commented 4 years ago

Looking thru the readme I don't see any mentioning of expo-random, what made you think that you had to install it? 🤔

harshmaur commented 4 years ago

Yes. I figured. Infact with expo-random it crashed on android.

Also it should be clearer where to import the module. It should be before everything else in index.js.

I'll submit a PR

hirbod commented 4 years ago

Looking thru the readme I don't see any mentioning of expo-random, what made you think that you had to install it? 🤔

Coming from Expo Git and the original ticket issuing this problem and having a lot of mentions about expo-random from brent :D At the end, the original expo ticket made me assume it.

LinusU commented 4 years ago

added a comment in that thread: https://github.com/expo/expo/issues/7209#issuecomment-712229139