Fix iOS clang module import for Expo SDK 44

LinusU / react-native-get-random-values

A small implementation of `getRandomValues` for React Native

MIT License

354 stars 48 forks source link

Fix iOS clang module import for Expo SDK 44 #33

Closed Kudo closed 2 years ago

Kudo commented 2 years ago

from https://github.com/expo/expo/issues/15622#issuecomment-997225774, the double-quoted react header imports will break building on Expo SDK 44. The double-quoted imports should be for react-native < 0.40. as nowadays react-native uses CocoaPods, it should be safe to use the angle-bracket import.

Bardiamist commented 2 years ago

I'm wating for this merge

LinusU commented 2 years ago

Since we only support React Native 0.56 and newer this shouldn't be a breaking change, thanks for the PR!

LinusU commented 2 years ago

Released as 🚢 1.7.2 / 2021-12-22

Kudo commented 2 years ago

@LinusU awesome! thanks for helping this update 🚀