LinusU / secure-remote-password

A modern SRP implementation for Node.js and Web Browsers
102 stars 22 forks source link

🎉 Add proper browser support #5

Closed LinusU closed 6 years ago

alexgoldstone commented 6 years ago

Please note that webpack outputs the following:

WARNING in Circular dependency detected:
../s-r-p/browser/sha256.js -> ../s-r-p/lib/srp-integer.js -> ../s-r-p/lib/params.js -> ../s-r-p/browser/sha256.js

WARNING in Circular dependency detected:
../s-r-p/lib/params.js -> ../s-r-p/browser/sha256.js -> ../s-r-p/lib/srp-integer.js -> ../s-r-p/lib/params.js

WARNING in Circular dependency detected:
../s-r-p/lib/srp-integer.js -> ../s-r-p/lib/params.js -> ../s-r-p/browser/sha256.js -> ../s-r-p/lib/srp-integer.js

webpack: Compiled with warnings.

However I am pleased to advise that your new branch builds using Angular 4's standard toolchain without issue. I have only tested generation of Salt and Verifier as described in the Signing up stage in your README however this covers both crypto functions so should be enough. I haven't tested in Node yet but assume you have this covered.

LinusU commented 6 years ago

Good catch! Circular dependencies should be resolved 👌

Glad to hear that it works!

alexgoldstone commented 6 years ago

Confirmed! The code still runs successfully and the circular dependency has gone.

Thank you for taking the time to resolve this. I will be able to proceed with testing SRP end-to-end and will report back to hopefully confirm successful testing.

LinusU commented 6 years ago

Awesome, I'll merge and tag a release 🎉

Thank you for using the library! The more people that uses it the more successful it will be 💌

LinusU commented 6 years ago

Published as 0.2.1 🚀