Linutronix / elbe

Embedded Linux Build Environment
https://elbe-rfs.org
GNU General Public License v3.0
165 stars 59 forks source link

Double slash in primary_mirror url #272

Closed c0ffee closed 2 years ago

c0ffee commented 4 years ago

In the sample xml files we add before the path always a "/", but at different places of the generator we had an additional "/" between the primary_host and primary_path. In my case the webserver rejects the request because the path is not correct.

So my quick solution was to remove the "/" in the config xml with the result that now all preprocessing steps suceeded. Sadly for the preseed configuration we dont add the spare "/" (https://github.com/Linutronix/elbe/blob/7dc7af030002ce7dd4d81ea77374007518df0b6e/elbepack/init/preseed.cfg.mako)

During the debian installer the choose-mirror tool expects now that the slash is included, at the end they use a simple %s%s in their fmt string.

In my opinion the cleanest solution would be to remove the extra "/" in the elbe code so that we are as close as possible to the debian way. For a user who forgets to add the "/" in their config it should fail quite early in the build process and for sure it is easier to debug than trying to fetch the log of the installer in the qemu image ;)