Closed d4nuu8 closed 2 years ago
Your commit message is missing some very important information: "Why is this change needed?"
Configuration packages are cleaner than blindly overwriting configuration files. Please explain the motivation for such a change.
Configuration packages are cleaner than blindly overwriting configuration files.
Yes, I would agree to this if the configuration package would deliver a explicitly defined configuration file. I would not agree to how it is done at the moment.
Relying on a package's (in this case lighttpd
) default configuration and just replacing a bit here and a bit there with sed
is nothing I would do.
So the initial intention was to get rid from the usage of sed
and check-in a explicitly defined configuration.
One maybe better approach than what this patch is doing, could be to add the configuration file to the python3-elbe-buildenv
package and add lighttpd
as a dependency to it.
What do you think?
I disagree that using sed to make the necessary changes is a bad thing. Modifying the default configuration is exactly what I would do if I were configuring lighttpd by hand. It also makes it clear what is being configured.
But if you insist on providing a new file, that can also be done with debathena. I don't understand your aversion towards debathena. It is the most elegant method of managing configuration changes.
Why would I insist? You guys are maintaining this thing. 😉
Thanks for your time and opinion on this.
I'm closing this pull request.
This patch replaces the currently used mechanism to deploy a lighttpd configuration to the intitvm.
Instead of creating the debathena-transform-lighttpd Debian package, the configuration will be deployed by preseeding to the initvm.
Signed-off-by: Daniel Braunwarth daniel@braunwarth.dev