search

LinuxBozo / jsonresume-theme-kendall

A theme for jsonresume
MIT License
57 stars 80 forks source link

Social profiles icon generation #14

Closed paskal closed 7 years ago

paskal commented 7 years ago

Hello!

Your theme is awesome, but I'm stuck with one issue: no matter how I name StackOverflow profile in resume.json, it generates fa-stackoverflow-square icon instead of fa-stack-overflow, could you please update that profile definitions to match more possible variants? Current code seems not working with "stack-overflow" case for me and stackOveflow with CamelCase on second word only seems counter-intuitive:

            case "stack-overflow":
            case "stackOverflow":
                p.iconClass = "fa fa-stack-overflow";
break;

I propose to include StackOverflow, Stack-Overflow, stackoverflow, and review other profiles as well. Also, case statement could be checked - in my setup it's somewhy not working as expected, I'll be glad to give you my environment data if you'll tell me which is relevant.

paskal commented 7 years ago

I've just rechecked, stackOverflow and stackoverflow in resume.json doesn't give you proper icon, only stack-overflow works and only with resume-cli generator, not with hackmyresume.

Also it will be nice to have a telegram icon there as well.

LinuxBozo commented 7 years ago

Should be fixed by https://github.com/LinuxBozo/jsonresume-theme-kendall/commit/595708ebd7898e2e8031f083aeba69f533f17768

paskal commented 7 years ago

@LinuxBozo, you commits are beautiful, thank you very much for quick fix.

paskal commented 7 years ago

I guess, unnecessary requirement to profile names should be removed from README.md:

every field in the basics.profiles array must be entered lowercase, without spaces.

LinuxBozo commented 7 years ago

Good catch. README updated: https://github.com/LinuxBozo/jsonresume-theme-kendall/commit/bd1db6b24e8e55486afc1d1037a8cdf0d721ea14