search

LinuxBozo / jsonresume-theme-kendall

A theme for jsonresume
MIT License
57 stars 80 forks source link

PDF output improvement #15

Closed paskal closed 6 years ago

paskal commented 7 years ago

Hello!

If you export kendall html resume to pdf, (xvfb-run wkhtmltopdf kendall.html kendall.pdf) it have two issues, first, it loses avatar: image And second, it have awkward line breaks: image I guess, avatar should be added to printed output, and some parts of content should be marked as unbreakable so they will be moved to next page on print.

LinuxBozo commented 7 years ago

The avatar not displaying during print is a design decision. See: https://github.com/LinuxBozo/jsonresume-theme-kendall/blob/master/print.css#L10

You are correct about awkward page breaks though. Solved in https://github.com/LinuxBozo/jsonresume-theme-kendall/commit/fcda74eb131f72df02a34a10107b74d72c752f0a

paskal commented 7 years ago

Hello again! I've noticed something strange with skills header when I'm printing page from Firefox 54, could you please take a look? (there were images) Experience section of the first skill from second page leaped to "skills" header.

UPD: Firefox 58 rendering PDF good, removed screenshots to clean the thread.

paskal commented 6 years ago

Dear @LinuxBozo, current line breaks are too tough: they leave up to half of a page empty: image I suggest to apply "non-breakable" property to smaller blocks than full "job and all it's highlights" block.

paskal commented 6 years ago

If I remove .job and .job-details from this property, I get following skills mess somewhy: image

paskal commented 6 years ago

@LinuxBozo, could you please take a look? I've give it a thought but can't find easy way to fix it taking what I've wrote before into account. UPD: actually, commenting out only .job-details from page-break-inside: avoid; fix things without breaking anything! I suggest to go with this solution.

LinuxBozo commented 6 years ago

@paskal I'll see if I can get some time this week to look into this.

LinuxBozo commented 6 years ago

@paskal ok, should be better in d10ddbd Have published new version.