LinuxCNC / linuxcnc

LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more.
http://linuxcnc.org/
GNU General Public License v2.0
1.81k stars 1.16k forks source link

Qtdragon NGCGui not rendering UI #2286

Open ihabmmali opened 1 year ago

ihabmmali commented 1 year ago

Here are the steps I follow to reproduce the issue:

  1. Compile latest version of linuxcnc 2.10 from git source
  2. Launch the qtdragon_hd sim configuration
  3. Navigate to Utils->NGCGUI Tab

This is what I expected to happen:

See the usual NGCGui dialogue for creating features

This is what happened instead:

We get an empty table with a single line text input box that seems to be disabled:

image

It worked properly before this:

Pre 2.9->2.10 merge

Information about my hardware and software:

c-morley commented 1 year ago

Can you run in a terminal and see if there are relative debug information?

ihabmmali commented 1 year ago

I have been running from command line and I cant see any unusual debug level errors: image

Interestingly, if I destroy the tabs and create a new one and load the same ngcgui sub file then it works: image

I then get these additional debug lines in the terminal image

ihabmmali commented 1 year ago

I played around with the ini and changed the NGCGUI_SUBFILE_PATH from the default of the sim file to the fully qualified path(so ~/linuxcnc/nc_files/examples/ngcgui_lib instead of the relative file path ../../../nc_files/ngcgui_lib/) and the ngcgui tabs load properly. I think it wasn't actually finding the sub files when using the relative path because the relative path had an extra "../". I think error handling is probably not working as expected? I guess it shouldn't attempt to create the tabs if the files are not found.

And sorry I just noticed it wasn't actually finding the files even in the previous screen shot...should have caught the error and corrected the path. image

c-morley commented 1 year ago

Ok tha's for that. I think it would be better if it showed a message on the tab that the path couldn't be found.

c-morley commented 1 year ago

My guess here is that as installed files get removed around, the relative path doesn't point in the right place anymore - it works fine in RIP. I'll try to get back to this.