search

LinuxCNC / linuxcnc

LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more.
http://linuxcnc.org/
GNU General Public License v2.0
1.78k stars 1.14k forks source link

Unstable 'raster' test reports Test failed: name 'output' is not defined #2644

Open petterreinholdtsen opened 11 months ago

petterreinholdtsen commented 11 months ago

In https://github.com/LinuxCNC/linuxcnc/pull/2643, which added new PO files, one of the build tests failed with the following error:

Running test: /home/runner/work/linuxcnc/linuxcnc/tests/raster
*** /home/runner/work/linuxcnc/linuxcnc/tests/raster: XFAIL: test run exited with 1
************** result:
        error: Test failed: name 'output' is not defined
************** stderr:
        Note: Using POSIX non-realtime
        Note: Using POSIX non-realtime
**************

As far as I can tell, this test failure have nothing to do with the patch, and seem more to be due to a unstable testsuite check.

The test program set up a collection of HAL pins and use these to test the behaviour. Could it be some race condition in the HAL processing?

rene-dev commented 11 months ago

the raster test tries to link hal pins while the comp is loading. should really call component_is_ready to wait for tje pins. https://github.com/LinuxCNC/linuxcnc/blob/master/src/hal/halmodule.cc#L1829 except it cant, because it uses different hal python bindings.

rene-dev commented 11 months ago

it cant be changed to use halmodule, as halmodule doesnt support hal ports. https://www.youtube.com/watch?v=LFrdqQZ8FFc