search

LinuxCNC / linuxcnc

LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more.
http://linuxcnc.org/
GNU General Public License v2.0
1.81k stars 1.16k forks source link

Typo in Motion.c #2773

Closed TurboStreetCar closed 10 months ago

TurboStreetCar commented 11 months ago

Hello, it seems there’s a typo in the names_misc_errors array definitions inside of motion.c.

It appears it’s using the count of array elements of names_dout instead of names_misc_errors, which effectively prevents you from using the names_misc_errors option.

Line number 348-351.

else if(names_misc_errors[0]){ num_misc_error = count_names(names_dout); num_misc_error = (num_misc_error > count_names(names_din)) ? num_misc_error : count_names(names_din); }

ArchMachineCo commented 11 months ago

Ive submitted a pull request on this issue.

hansu commented 11 months ago

Please link to the corresponding pull request next time: https://github.com/LinuxCNC/linuxcnc/pull/2780

andypugh commented 10 months ago

Fixed via https://github.com/LinuxCNC/linuxcnc/commit/74288982e684e03b567d9850efdd105dc209b1f4