search

LinuxCNC / linuxcnc

LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more.
http://linuxcnc.org/
GNU General Public License v2.0
1.77k stars 1.14k forks source link

Gmoccapy, don't hide recurring error messages #2814

Closed Sigma1912 closed 6 months ago

Sigma1912 commented 8 months ago

The original code will suppress showing an error message if it is identical to the one shown last. While this seems to make some sense at first glance it leads to confusing situations where the user thinks an error has been fixed while it actually still exists but is hidden by the gui.

gmoccapy commented 8 months ago

I think I have done that that way, because I had an error with pop up every poll, so I had 100#erts of pop up windows.

Have you tested well the possible situations?

Norbert

Sigma1912 commented 8 months ago

I think I have done that that way, because I had an error with pop up every poll, so I had 100#erts of pop up windows.

I suspected that may have been the reason. I have not had that happen yet, can you remember in what case you got that behavior?

hansu commented 8 months ago

We could also change the type of warning dialog.

For example when I open a file with an error, I get this dialog: grafik But this doesn't prevent the file from loading, so a dialog like this could also be used (this info box appears when I try to start the program): grafik For this messages we already have the possibility to limit the number of displayed messages.

andypugh commented 8 months ago

Assigning this to Norbert, I feel this should be his final decision.