search

LinuxCNC / linuxcnc

LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more.
http://linuxcnc.org/
GNU General Public License v2.0
1.73k stars 1.13k forks source link

Restrict libgpiod to < 2.0.0 when configuring #2883

Closed havardAasen closed 4 months ago

havardAasen commented 5 months ago

This restricts libgpiod to versions < 2.0.0. mainly to prevent build failures if the system has any later version installed, which LinuxCNC does not support.

This prevents build failure noticed in #2842 but does of course not do anything to support the new API.

Using pkg-config to do the heavy lifting.

andypugh commented 5 months ago

Supporting the new API is on my list of things to do. And fairly high up.

havardAasen commented 5 months ago

Supporting the new API is on my list of things to do. And fairly high up.

Nice, you want to handle the build system as well?

This PR fails because it's missing aclocal.m4, could update src/autogen.sh to run aclocal before autoconf.

I haven't looked into this file before, it seems we handcraft a lot of things. Could we swap out everything in src/autogen.sh with autoreconf --force --install?

edit: Seems this was proposed and deemed to risky in #1625

petterreinholdtsen commented 5 months ago

[Håvard]

I haven't looked into this file before, it seems we handcraft a lot of things. Could we swap out everything in src/autogen.sh with autoreconf --force --install?

Sound like a good idea to me.

-- Happy hacking Petter Reinholdtsen