search

LinuxCNC / linuxcnc

LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more.
http://linuxcnc.org/
GNU General Public License v2.0
1.73k stars 1.13k forks source link

GCode Graphics - Show Bounding box of part when not showing preview. #2887

Closed satiowadahc closed 4 months ago

satiowadahc commented 4 months ago

Some files >1000000 lines or so, take a lot of resources to preview. Replacing the preview with a bounding box heavily reduces this issue.

While trying to find a good solution, IDE's are screaming at errors in this file, which I tried only addressing severe ones, such as reusing variables, while loop that was removed, unused imports, using builtin names, removed unused variables.

I tested with axis, qtdragon, our own gui. Foam and Mill versions.

c-morley commented 4 months ago

Could you rebase this on master? I think Andy would agree that the changes are too big for 2.9

c-morley commented 4 months ago

Great idea by the way.

satiowadahc commented 4 months ago

Thanks! I could rebate... would you consider if I skip the code cleanup and just add the bounding box to 2.9?

c-morley commented 4 months ago

I can't speak for @andypugh - it's his decision, but I would think it would be acceptable as the changes are small and managable to debug. I hope you would also make a pull request for the master for the rest of the work you did.

andypugh commented 4 months ago

2.9 should only be getting bug-fixes at this point. I think that anything like this belongs in Master.

satiowadahc commented 4 months ago

Closing in favour of #2897 #2896