search

LinuxCNC / linuxcnc

LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more.
http://linuxcnc.org/
GNU General Public License v2.0
1.73k stars 1.13k forks source link

Remove erroneous quote. #2904

Closed newellshk closed 4 months ago

newellshk commented 4 months ago

I noticed this because it messed up the syntax highlighting in my editor. I have close to zero experience with tcl so I hope it's correct...

andypugh commented 4 months ago

This does look wrong, but I don't know enough about Tcl to know if it really is wrong.

hansu commented 4 months ago

Syntactically this is correct even though it seems not to make much sense. It just extends the string in which will be searched by a quotation mark. But it doesn't hurt because the string the string <csection> will be found in <section> as well as in <section>+".

andypugh commented 4 months ago

I still don't know if rmu (on the IRC) or yourself are advocating for this change or against it.

I understand that it will break syntax highlighting in many editors.

Perhaps the quote (if useful) could be escaped or quoted in some way?

hansu commented 4 months ago

I think this is quite safe to merge. It searches in the INI section names and they don't contain a quote. Furthermore I double-checked with the background knowledge of the corresponding change: https://github.com/LinuxCNC/linuxcnc/commit/6a3d0a434ebed19c41aecb3e6d09c712e1971b52