search

LinuxCNC / linuxcnc

LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more.
http://linuxcnc.org/
GNU General Public License v2.0
1.73k stars 1.13k forks source link

Update gmoccapy.py: fix false display of 'G92.2'/'G92.3' in active Godes #2923

Closed Sigma1912 closed 4 months ago

Sigma1912 commented 4 months ago

see: (https://github.com/LinuxCNC/linuxcnc/issues/2743)

hansu commented 4 months ago

You have based your commit on master but this PR is targeted to 2.9. As I think this should go into 2.9 I would please you to rebase your branch to 2.9.

c-morley commented 4 months ago

I've been following along on this issue in the background a bit. Do you think the right fix is to patch all the GUIs to checkbthis? This seems the wrong approach.

hansu commented 4 months ago

I haven't yet looked into the G92 issues in detail, so I cannot say much to the fix(es).

Sigma1912 commented 4 months ago

Thanks for the feed back. Have a look at the comments in the issue #2743.