search

LinuxCNC / linuxcnc

LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more.
http://linuxcnc.org/
GNU General Public License v2.0
1.73k stars 1.13k forks source link

Remove StateTag tag. As it is never used. #2995

Open krcwrhvgyxzqelljes opened 3 weeks ago

krcwrhvgyxzqelljes commented 3 weeks ago

/home/user/linuxcnc/src/emc/rs274ngc/interp_convert.cc

Line 4357

StateTag tag;

This can be deleted as it is never used.

andypugh commented 3 weeks ago

In which version? In master it is: https://github.com/LinuxCNC/linuxcnc/blob/master/src/emc/rs274ngc/interp_convert.cc#L4357 In 2.9 it is https://github.com/LinuxCNC/linuxcnc/blob/2.9/src/emc/rs274ngc/interp_convert.cc#L4357

rmu75 commented 1 week ago

https://github.com/LinuxCNC/linuxcnc/blob/2.9/src/emc/rs274ngc/interp_convert.cc#L3811 https://github.com/LinuxCNC/linuxcnc/blob/master/src/emc/rs274ngc/interp_convert.cc#L4352

andypugh commented 1 week ago

OK, yes, that seems to never be used in that scope. The compiler probably ignores it, but it does seem untidy.