search

LinuxCNC / linuxcnc

LinuxCNC controls CNC machines. It can drive milling machines, lathes, 3d printers, laser cutters, plasma cutters, robot arms, hexapods, and more.
http://linuxcnc.org/
GNU General Public License v2.0
1.79k stars 1.15k forks source link

Correcting typos. gardenweazel #3001

Closed 6XoCtujg2C0gne closed 3 months ago

6XoCtujg2C0gne commented 3 months ago

Correcting typos in code.

petterreinholdtsen commented 3 months ago

The changes look good, but something is broken with the tests.

6XoCtujg2C0gne commented 3 months ago

I may have clobbered the first try. This was my first time submitting.

--Andy L.

From: petterreinholdtsen @.> Sent: Tuesday, July 2, 2024 10:30 AM To: LinuxCNC/linuxcnc @.> Cc: Andy (gardenweazel) Lewis @.>; Author @.> Subject: Re: [LinuxCNC/linuxcnc] Correcting typos. gardenweazel (PR #3001)

The changes look good, but something is broken with the tests.

— Reply to this email directly, view it on GitHub https://github.com/LinuxCNC/linuxcnc/pull/3001#issuecomment-2203535767 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFIKPIJ6N4YZUNEGKPNMHTZKLBQLAVCNFSM6AAAAABKHXLRNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBTGUZTKNZWG4 . You are receiving this because you authored the thread. https://github.com/notifications/beacon/ABFIKPIGDNEU6WW3SUOGTETZKLBQLA5CNFSM6AAAAABKHXLRNKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUDK5EZO.gif Message ID: @. @.> >

andypugh commented 3 months ago

I am not sure why the checks are failing, I am pretty sure that it isn't your PR.

andypugh commented 3 months ago

I don't think it is the tests, 

E: Invalid archive signature
E: Internal error, could not locate member control.tar{.zst,.lz4,.gz,.xz,.bz2,.lzma,}
Reading package lists...
E: Could not read meta data from /__w/linuxcnc/linuxcnc/po4a_0.67-2_all.deb
E: The package lists or status file could not be parsed or opened.
rmu75 commented 3 months ago

for whatever reason the download of po4a_0.67-2_all.deb failed without saying so, it got only 279 bytes instead of 2146k. rip-and-test-clang did work, so maybe intermittend failure of the debian mirror -- running the test again will probably succeed.

petterreinholdtsen commented 3 months ago

[Robert Schöftner]

for whatever reason the download of po4a_0.67-2_all.deb failed without saying so, it got only 279 bytes instead of 2146k. rip-and-test-clang did work, so maybe intermittend failure of the debian mirror -- running the test again will probably succeed.

Did github introduce some network limitations blocking the download, perhaps. Not sure how to debug it. The failing tests are definitely not related to this pull request.

I guess a ugly workaround would be to commit a po4a deb to git and install from there instead...

-- Happy hacking Petter Reinholdtsen

rmu75 commented 3 months ago

would be interesting what the downloaded 279-byte file actually contains. maybe the debian snapshot mirror introduced some restrictions for github?

andypugh commented 3 months ago

First of all, apologies to the original requestor. We will get round to your PR. I would have just merged it after inspection, but you have changed the text of a debug output, so I want to see the test suite pass first. It is possible that a test is looking at that text. (though unlikely)

What does "Invalid Archive Signature" mean?

rmu75 commented 3 months ago

What does "Invalid Archive Signature" mean?

debian .deb files are ar(1) archives, so i guess the file contains something like a 404 error message and therefor is not a valid ar archive.

andypugh commented 3 months ago

The CI might be fixed, it might not, I don't care any more.

It's certainly not a reason to decline this PR. Thanks.